Skip to content

Commit

Permalink
Move quotes at the end as we do for other paths (#1579)
Browse files Browse the repository at this point in the history
* Move quotes at the end as we do for other paths

Signed-off-by: Pablo Chico de Guzman <pchico83@gmail.com>

* Fix typos

Signed-off-by: Pablo Chico de Guzman <pchico83@gmail.com>
  • Loading branch information
pchico83 committed May 28, 2021
1 parent a4ddb1c commit 84d0eb4
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion images/bin/start.sh
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ while getopts ":s:ervd" opt; do
;;
d)
if [ -z "${DOCKER_CONFIG}" ]; then
DOCKER_CONFIG="$HOME"/.docker
DOCKER_CONFIG="$HOME/.docker"
fi
if [ ! -d "${DOCKER_CONFIG}" ]; then
mkdir -p "${DOCKER_CONFIG}"
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/stack/translate_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -511,7 +511,7 @@ func Test_translateJob(t *testing.T) {
t.Errorf("Wrong job spec.parallelism: '%d'", *result.Spec.Parallelism)
}
if *result.Spec.BackoffLimit != 5 {
t.Errorf("Wrong job spec.max_attemps: '%d'", *result.Spec.BackoffLimit)
t.Errorf("Wrong job spec.max_attempts: '%d'", *result.Spec.BackoffLimit)
}
if !reflect.DeepEqual(result.Spec.Template.Labels, labels) {
t.Errorf("Wrong spec.template.labels: '%s'", result.Spec.Template.Labels)
Expand Down
2 changes: 1 addition & 1 deletion pkg/model/stack.go
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ type Service struct {
StopGracePeriod int64 `yaml:"stop_grace_period,omitempty"`
Volumes []StackVolume `yaml:"volumes,omitempty"`
Workdir string `yaml:"workdir,omitempty"`
BackOffLimit int32 `yaml:"max_attemps,omitempty"`
BackOffLimit int32 `yaml:"max_attempts,omitempty"`

Public bool `yaml:"public,omitempty"`
Replicas int32 `yaml:"replicas,omitempty"`
Expand Down
4 changes: 2 additions & 2 deletions pkg/model/stack_serializer_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -859,9 +859,9 @@ func Test_UnmarshalRestart(t *testing.T) {
t.Run(tt.name, func(t *testing.T) {
s, err := ReadStack(tt.manifest, false)
if tt.throwErr && err == nil {
t.Fatal("Not throwed error")
t.Fatal("Not threw error")
} else if err != nil && !tt.throwErr {
t.Fatalf("Throwed error when no error needed: %s", err.Error())
t.Fatalf("Threw error when no error needed: %s", err.Error())
}
if err == nil && s.Services["app"].RestartPolicy != tt.result {
t.Fatal("Wrong unmarshal")
Expand Down

0 comments on commit 84d0eb4

Please sign in to comment.