Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depends_on fails across stack manifests #1891

Closed
spearki opened this issue Oct 28, 2021 · 0 comments · Fixed by #1928
Closed

depends_on fails across stack manifests #1891

spearki opened this issue Oct 28, 2021 · 0 comments · Fixed by #1928
Assignees
Labels
bug Something isn't working low planned

Comments

@spearki
Copy link

spearki commented Oct 28, 2021

Describe the bug
In a stack defined with multiple docker-compose manifests, depends_on fails if a service in one manifest depends on a service in a different manifest.

This seems to be because depends_on is validated during unmarshalling:

if err := validateDependsOn(s); err != nil {

To Reproduce
Steps to reproduce the behavior:

db.yml:
  services:
    db:
      image: mariadb

app.yml:
  services:
    app:
      image: nginx
      depends_on:
      - db
$ okteto stack deploy -f db.yml -f app.yml
 x   Service 'app' depends on service 'db' which is undefined.

Expected behavior
depends_on should work across files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working low planned
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants