Jlopezbarb/fix depends on error #1928
Conversation
Signed-off-by: Javier López Barba <javier@okteto.com>
Signed-off-by: Javier López Barba <javier@okteto.com>
Signed-off-by: Javier López Barba <javier@okteto.com>
Codecov Report
@@ Coverage Diff @@
## master #1928 +/- ##
==========================================
+ Coverage 33.67% 33.71% +0.03%
==========================================
Files 121 121
Lines 13736 13736
==========================================
+ Hits 4626 4631 +5
+ Misses 8610 8603 -7
- Partials 500 502 +2
Continue to review full report at Codecov.
|
pkg/model/stack.go
Outdated
| return fmt.Errorf(" Service '%s' depends on service '%s' which is undefined.", svcName, dependentSvc) | ||
| } | ||
| if condition.Condition == DependsOnServiceCompleted && !s.Services[dependentSvc].IsJob() { | ||
| return fmt.Errorf(" Service '%s' is not a job. Please change the reset policy so that it is not always in service '%s' ", dependentSvc, dependentSvc) |
There was a problem hiding this comment.
I don't understand this sentence:
Please change the reset policy so that it is not always in service
There was a problem hiding this comment.
It means that they have set a DependsOnServiceCompleted with a service with a restart policy set to always. We only support that kind of condition with jobs where the restart policy can not be always.
It was the error that we had but it's not explained properly. Any suggestion?
There was a problem hiding this comment.
@rberrelleza ?? It should say restart policy, not reset policy
Signed-off-by: Javier López Barba <javier@okteto.com>
Fixes #1891
Proposed changes