Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default to node 12 #1043

Merged
merged 1 commit into from
Sep 18, 2020
Merged

default to node 12 #1043

merged 1 commit into from
Sep 18, 2020

Conversation

rberrelleza
Copy link
Member

Proposed changes

  • use okteto/node:12 instead of node:10 for the dev env

@derek
Copy link

derek bot commented Sep 18, 2020

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

@derek derek bot added the no-dco label Sep 18, 2020
@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #1043 into master will decrease coverage by 1.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1043      +/-   ##
==========================================
- Coverage   37.45%   36.33%   -1.12%     
==========================================
  Files          59       59              
  Lines        5610     4998     -612     
==========================================
- Hits         2101     1816     -285     
+ Misses       3333     3013     -320     
+ Partials      176      169       -7     
Impacted Files Coverage Δ
pkg/linguist/dev.go 78.63% <100.00%> (-0.12%) ⬇️
cmd/up/pid.go 45.45% <0.00%> (-8.40%) ⬇️
pkg/ssh/pool.go 52.08% <0.00%> (-6.85%) ⬇️
pkg/ssh/reverse.go 66.66% <0.00%> (-6.07%) ⬇️
pkg/ssh/forward.go 65.71% <0.00%> (-5.72%) ⬇️
pkg/model/port.go 50.00% <0.00%> (-5.56%) ⬇️
pkg/ssh/client.go 66.66% <0.00%> (-4.77%) ⬇️
pkg/ssh/manager.go 63.15% <0.00%> (-4.24%) ⬇️
pkg/cmd/down/wait.go 72.72% <0.00%> (-4.20%) ⬇️
pkg/ssh/config.go 70.27% <0.00%> (-3.98%) ⬇️
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8112f5d...8194aea. Read the comment docs.

@pchico83 pchico83 merged commit 857147f into master Sep 18, 2020
@pchico83 pchico83 deleted the node-12 branch September 18, 2020 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants