Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infer the repo and branch on pipeline deploy if not specified #1075

Merged
merged 4 commits into from
Oct 7, 2020

Conversation

rberrelleza
Copy link
Member

Fixes #1026 and #1027

Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Copy link
Contributor

@pchico83 pchico83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@64ddea1). Click here to learn what that means.
The diff coverage is 48.78%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1075   +/-   ##
=========================================
  Coverage          ?   34.28%           
=========================================
  Files             ?       65           
  Lines             ?     5366           
  Branches          ?        0           
=========================================
  Hits              ?     1840           
  Misses            ?     3333           
  Partials          ?      193           
Impacted Files Coverage Δ
cmd/pipeline/deploy.go 16.66% <48.78%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64ddea1...7c20d2f. Read the comment docs.

Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
@derek derek bot added the no-dco label Oct 7, 2020
@derek
Copy link

derek bot commented Oct 7, 2020

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically detect the current repository when running a pipeline
2 participants