Sort stack envvars before deploying stack services #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pablo Chico de Guzman <pchico83@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1079 +/- ##
=========================================
Coverage ? 35.01%
=========================================
Files ? 62
Lines ? 5207
Branches ? 0
=========================================
Hits ? 1823
Misses ? 3194
Partials ? 190
Continue to review full report at Codecov.
|
rberrelleza
reviewed
Oct 6, 2020
| @@ -58,6 +60,9 @@ func translateEnvVars(s *model.Stack) error { | |||
| for _, envFilepath := range svc.EnvFiles { | |||
| translateEnvFile(&svc, envFilepath) | |||
| } | |||
| sort.SliceStable(svc.Environment, func(i, j int) bool { | |||
There was a problem hiding this comment.
why do we need to do this? To make it easier to read?
There was a problem hiding this comment.
Kubernetes redeploys pods if envvars have a different order. This is very inconvenient with stefulsets, for example. If my stack yaml does change, it shouldn't be expected that pods are redeployed
rberrelleza
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pablo Chico de Guzman pchico83@gmail.com
Proposed changes