Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image error #1142

Merged
merged 3 commits into from
Oct 28, 2020
Merged

Image error #1142

merged 3 commits into from
Oct 28, 2020

Conversation

rberrelleza
Copy link
Member

Fixes #1128

image

Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
@codecov
Copy link

codecov bot commented Oct 28, 2020

Codecov Report

Merging #1142 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1142      +/-   ##
==========================================
- Coverage   33.79%   33.77%   -0.02%     
==========================================
  Files          65       65              
  Lines        5424     5427       +3     
==========================================
  Hits         1833     1833              
- Misses       3395     3398       +3     
  Partials      196      196              
Impacted Files Coverage Δ
cmd/up/up.go 3.98% <0.00%> (-0.03%) ⬇️
pkg/k8s/pods/pod.go 13.05% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a2e121...a28f28f. Read the comment docs.

@derek
Copy link

derek bot commented Oct 28, 2020

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

@derek derek bot added the no-dco label Oct 28, 2020
@rberrelleza rberrelleza merged commit 627db34 into master Oct 28, 2020
@rberrelleza rberrelleza deleted the image-error branch October 28, 2020 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unhelpful error message and slow response on okteto up for a missing image
2 participants