Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retrieve port from SSH config if the port is not defined. #1146

Merged
merged 2 commits into from
Nov 2, 2020

Conversation

rberrelleza
Copy link
Member

Signed-off-by: Ramiro Berrelleza rberrelleza@gmail.com

improves #1145

Proposed changes

  • If the port is not defined in the manifest, and remote mode is enabled, we retrieve the port from the ssh config entry.

Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
@codecov
Copy link

codecov bot commented Nov 2, 2020

Codecov Report

Merging #1146 into master will increase coverage by 0.13%.
The diff coverage is 53.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1146      +/-   ##
==========================================
+ Coverage   33.78%   33.92%   +0.13%     
==========================================
  Files          65       65              
  Lines        5434     5448      +14     
==========================================
+ Hits         1836     1848      +12     
+ Misses       3402     3401       -1     
- Partials      196      199       +3     
Impacted Files Coverage Δ
pkg/config/config.go 29.82% <0.00%> (ø)
pkg/ssh/ssh.go 73.84% <57.14%> (-0.67%) ⬇️
pkg/ssh/config.go 70.27% <0.00%> (+1.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fc68f0...8a620a7. Read the comment docs.

Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
@rberrelleza rberrelleza merged commit 8d5de6b into master Nov 2, 2020
@rberrelleza rberrelleza deleted the load-from-sshconfig branch November 2, 2020 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants