Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reconnect on transient network errors #1148

Merged
merged 8 commits into from
Nov 4, 2020
Merged

reconnect on transient network errors #1148

merged 8 commits into from
Nov 4, 2020

Conversation

rberrelleza
Copy link
Member

Proposed changes

  • retry on the main loop for transient errors
  • properly close ports during shutdown

Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
@codecov
Copy link

codecov bot commented Nov 4, 2020

Codecov Report

Merging #1148 into master will decrease coverage by 0.13%.
The diff coverage is 5.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1148      +/-   ##
==========================================
- Coverage   34.13%   34.00%   -0.14%     
==========================================
  Files          65       65              
  Lines        5467     5491      +24     
==========================================
+ Hits         1866     1867       +1     
- Misses       3398     3421      +23     
  Partials      203      203              
Impacted Files Coverage Δ
cmd/up/up.go 3.91% <0.00%> (-0.06%) ⬇️
pkg/ssh/exec.go 0.00% <0.00%> (ø)
pkg/ssh/pool.go 53.70% <50.00%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a078afd...a8743bf. Read the comment docs.

Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
@rberrelleza rberrelleza merged commit 2221ce1 into master Nov 4, 2020
@rberrelleza rberrelleza deleted the simple-reconnect branch November 4, 2020 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants