Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close port forwards on the activate loop #1149

Merged
merged 8 commits into from
Nov 4, 2020
Merged

Conversation

rberrelleza
Copy link
Member

Proposed changes

  • Properly close the SSH port-forwards on the activate loop

Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
@codecov
Copy link

codecov bot commented Nov 4, 2020

Codecov Report

Merging #1149 into master will increase coverage by 0.22%.
The diff coverage is 58.49%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1149      +/-   ##
==========================================
+ Coverage   33.90%   34.13%   +0.22%     
==========================================
  Files          65       65              
  Lines        5450     5467      +17     
==========================================
+ Hits         1848     1866      +18     
+ Misses       3403     3398       -5     
- Partials      199      203       +4     
Impacted Files Coverage Δ
cmd/up/up.go 3.96% <0.00%> (-0.01%) ⬇️
pkg/ssh/pool.go 52.83% <46.15%> (+0.65%) ⬆️
pkg/ssh/reverse.go 55.00% <46.66%> (-4.46%) ⬇️
pkg/ssh/forward.go 72.72% <68.42%> (+20.22%) ⬆️
pkg/ssh/manager.go 63.46% <100.00%> (+3.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 691fde8...816e461. Read the comment docs.

Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
@rberrelleza rberrelleza merged commit a078afd into master Nov 4, 2020
@rberrelleza rberrelleza deleted the close-port-forwards branch November 4, 2020 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants