Wait for shutdown sequence before a new retry #1150
Conversation
Signed-off-by: Pablo Chico de Guzman <pchico83@gmail.com>
pchico83
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1150 +/- ##
==========================================
- Coverage 34.00% 33.94% -0.06%
==========================================
Files 65 65
Lines 5491 5500 +9
==========================================
Hits 1867 1867
- Misses 3421 3430 +9
Partials 203 203
Continue to review full report at Codecov.
|
| } | ||
| iter++ | ||
| iter = iter % 10 | ||
| if isTransientError { |
There was a problem hiding this comment.
can we also add the log.Yellow here? or maybe use the same animation pattern that we do for the up? I'd like to make it visible that we're trying to reconnect rather than being stuck.
@rlamana what do you think?
There was a problem hiding this comment.
@rberrelleza the message is shown every 10s
cmd/up/up.go
Outdated
| @@ -957,6 +965,8 @@ func (up *upContext) shutdown() { | |||
| } | |||
|
|
|||
| log.Info("completed shutdown sequence") | |||
| up.Canceled <- true | |||
There was a problem hiding this comment.
can we rename this to up.ShutdownCompleted (or somethign like that), since this could happen on a regular shutdown as well, and not just when canceling?
Signed-off-by: Pablo Chico de Guzman <pchico83@gmail.com>
Signed-off-by: Pablo Chico de Guzman pchico83@gmail.com
Proposed changes