Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for args in stacks #1163

Merged
merged 1 commit into from
Nov 12, 2020
Merged

Support for args in stacks #1163

merged 1 commit into from
Nov 12, 2020

Conversation

pchico83
Copy link
Contributor

Signed-off-by: Pablo Chico de Guzman pchico83@gmail.com

Proposed changes

  • "command" and "args" are already supported in the stacks helm chart

Signed-off-by: Pablo Chico de Guzman <pchico83@gmail.com>
@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #1163 (88ddf36) into master (5965d0a) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1163      +/-   ##
==========================================
- Coverage   34.59%   34.51%   -0.08%     
==========================================
  Files          65       65              
  Lines        5429     5441      +12     
==========================================
  Hits         1878     1878              
- Misses       3347     3359      +12     
  Partials      204      204              
Impacted Files Coverage Δ
pkg/model/dev.go 53.43% <ø> (ø)
pkg/model/serializer.go 64.04% <0.00%> (-4.63%) ⬇️
pkg/model/stack.go 34.72% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5965d0a...88ddf36. Read the comment docs.

@pchico83 pchico83 merged commit c52377b into master Nov 12, 2020
@pchico83 pchico83 deleted the args branch November 12, 2020 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant