don't check if reverse is taken in the local machine #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1171 +/- ##
==========================================
+ Coverage 34.55% 34.57% +0.02%
==========================================
Files 65 65
Lines 5438 5440 +2
==========================================
+ Hits 1879 1881 +2
Misses 3355 3355
Partials 204 204
Continue to review full report at Codecov.
|
pchico83
reviewed
Nov 18, 2020
| @@ -48,7 +48,7 @@ func NewForwardManager(ctx context.Context, sshAddr, localInterface, remoteInter | |||
| } | |||
| } | |||
|
|
|||
| func (fm *ForwardManager) canAdd(localPort int) error { | |||
| func (fm *ForwardManager) canAdd(localPort int, checkAvailable bool) error { | |||
There was a problem hiding this comment.
checkAvailable is not used, doesn't it?
There was a problem hiding this comment.
I didn't push the last commit 🤦♂️
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
pchico83
approved these changes
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1170
Proposed changes