Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse same kubeconfig context for "okteto namespace" and "okteto name… #1232

Merged
merged 1 commit into from
Jan 4, 2021

Conversation

pchico83
Copy link
Contributor

…space xxx"

Signed-off-by: Pablo Chico de Guzman pchico83@gmail.com

Fixes #1231

…space xxx"

Signed-off-by: Pablo Chico de Guzman <pchico83@gmail.com>
@codecov
Copy link

codecov bot commented Dec 29, 2020

Codecov Report

Merging #1232 (d4a7fca) into master (5ea3f19) will decrease coverage by 0.29%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1232      +/-   ##
==========================================
- Coverage   34.49%   34.20%   -0.30%     
==========================================
  Files          67       67              
  Lines        5644     5616      -28     
==========================================
- Hits         1947     1921      -26     
+ Misses       3489     3488       -1     
+ Partials      208      207       -1     
Impacted Files Coverage Δ
pkg/okteto/credential.go 0.00% <0.00%> (ø)
pkg/okteto/client.go 44.57% <100.00%> (-12.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ea3f19...d4a7fca. Read the comment docs.

@rberrelleza
Copy link
Member

The idea with the current implementation is to have separate contexts per namespace, so it's easier to use them with other kubernetes tools without having to run "okteto namespace foo" every time.

What's the purpose of changing that behavior?

@pchico83
Copy link
Contributor Author

pchico83 commented Jan 4, 2021

Synched on issue #1231

@pchico83 pchico83 merged commit 0e0a36c into master Jan 4, 2021
@pchico83 pchico83 deleted the namespace branch January 4, 2021 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"okteto namespace" and "okteto namespace xxx" don't reuse kubeconfig context
2 participants