Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix namespace e2e tests #1234

Merged
merged 1 commit into from
Jan 4, 2021
Merged

Fix namespace e2e tests #1234

merged 1 commit into from
Jan 4, 2021

Conversation

pchico83
Copy link
Contributor

@pchico83 pchico83 commented Jan 4, 2021

Signed-off-by: Pablo Chico de Guzman pchico83@gmail.com

Proposed changes

  • If the personal namespace doesn't exist, get credentials can fail if the namespace is not specified

@codecov
Copy link

codecov bot commented Jan 4, 2021

Codecov Report

Merging #1234 (bc40fd7) into master (4abe2fa) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1234   +/-   ##
=======================================
  Coverage   34.23%   34.23%           
=======================================
  Files          67       67           
  Lines        5612     5612           
=======================================
  Hits         1921     1921           
  Misses       3484     3484           
  Partials      207      207           
Impacted Files Coverage Δ
pkg/okteto/credential.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4abe2fa...bc40fd7. Read the comment docs.

Signed-off-by: Pablo Chico de Guzman <pchico83@gmail.com>
@pchico83 pchico83 merged commit 9f41d86 into master Jan 4, 2021
@pchico83 pchico83 deleted the namespace-e2e branch January 4, 2021 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants