Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix integration test #1250

Merged
merged 2 commits into from
Jan 22, 2021
Merged

fix integration test #1250

merged 2 commits into from
Jan 22, 2021

Conversation

rberrelleza
Copy link
Member

Fix broken integration test due to function signature change

@derek
Copy link

derek bot commented Jan 22, 2021

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

@derek derek bot added the no-dco label Jan 22, 2021
Signed-off-by: Ramiro <rberrelleza@gmail.com>
@codecov
Copy link

codecov bot commented Jan 22, 2021

Codecov Report

Merging #1250 (d3cc586) into master (f1c9ac0) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1250   +/-   ##
=======================================
  Coverage   34.62%   34.62%           
=======================================
  Files          67       67           
  Lines        5638     5638           
=======================================
  Hits         1952     1952           
  Misses       3478     3478           
  Partials      208      208           
Impacted Files Coverage Δ
pkg/syncthing/install.go 39.32% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1c9ac0...d3cc586. Read the comment docs.

Signed-off-by: Ramiro <rberrelleza@gmail.com>
@derek derek bot removed the no-dco label Jan 22, 2021
@rberrelleza rberrelleza merged commit 5b7c712 into master Jan 22, 2021
@rberrelleza rberrelleza deleted the fix-integration branch January 22, 2021 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant