Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for .env files in okteto up #1360

Merged
merged 1 commit into from
Apr 27, 2021
Merged

support for .env files in okteto up #1360

merged 1 commit into from
Apr 27, 2021

Conversation

rberrelleza
Copy link
Member

Proposed changes

  • Read an available .env file on start, and inject the values to the environment for the rest of the commands

@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #1360 (ef4fc72) into master (b64902f) will decrease coverage by 0.15%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1360      +/-   ##
==========================================
- Coverage   36.24%   36.08%   -0.16%     
==========================================
  Files          79       80       +1     
  Lines        7261     7293      +32     
==========================================
  Hits         2632     2632              
- Misses       4301     4333      +32     
  Partials      328      328              
Impacted Files Coverage Δ
cmd/up/up.go 7.09% <0.00%> (-0.08%) ⬇️
cmd/utils/dev.go 39.36% <0.00%> (-10.64%) ⬇️
pkg/okteto/secrets.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b64902f...ef4fc72. Read the comment docs.

main.go Outdated Show resolved Hide resolved
@derek derek bot added the no-dco label Apr 9, 2021
@derek
Copy link

derek bot commented Apr 9, 2021

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

Signed-off-by: Pablo Chico de Guzman <pchico83@gmail.com>
@derek derek bot removed the no-dco label Apr 23, 2021
@pchico83 pchico83 merged commit 0752615 into master Apr 27, 2021
@pchico83 pchico83 deleted the support-dot-env branch April 27, 2021 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants