Add error if user has not the permissions for ns #1428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Javier López Barba <javier@okteto.com>
Codecov Report
@@ Coverage Diff @@
## master #1428 +/- ##
=======================================
Coverage 36.29% 36.29%
=======================================
Files 79 79
Lines 7237 7237
=======================================
Hits 2627 2627
Misses 4285 4285
Partials 325 325 Continue to review full report at Codecov.
|
rberrelleza
reviewed
Apr 19, 2021
cmd/namespace/namespace.go
Outdated
|
|
||
| _, err = namespaces.Get(ctx, namespace, client) | ||
| if err != nil { | ||
| return fmt.Errorf("Cannot get '%s' namespace. Please make sure it's created and you have the right permissions.", namespace) |
There was a problem hiding this comment.
Could we add the second sentence as a hint instead?
Suggested change
| return fmt.Errorf("Cannot get '%s' namespace. Please make sure it's created and you have the right permissions.", namespace) | |
| return fmt.Errorf("Namespace '%s' not found. Please verify that the namespace exists and that you have access to it.", namespace) |
pchico83
approved these changes
Apr 20, 2021
Signed-off-by: Javier López Barba <javier@okteto.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Javier López Barba javier@okteto.com
Fixes #1417
Proposed changes