Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check namespace access using the Okteto API #1438

Merged
merged 1 commit into from
Apr 21, 2021
Merged

Check namespace access using the Okteto API #1438

merged 1 commit into from
Apr 21, 2021

Conversation

pchico83
Copy link
Contributor

Fixes the okteto create namespace command in CI

@codecov
Copy link

codecov bot commented Apr 21, 2021 •
edited

Codecov Report

Merging #1438 (8ab77fb) into master (99c6f2f) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1438      +/-   ##
==========================================
- Coverage   36.33%   36.29%   -0.05%     
==========================================
  Files          79       79              
  Lines        7238     7247       +9     
==========================================
  Hits         2630     2630              
- Misses       4285     4294       +9     
  Partials      323      323
Impacted Files Coverage Δ
pkg/okteto/namespace.go 13.88% <0.00%> (-4.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99c6f2f...8ab77fb. Read the comment docs.

@pchico83
Check namespace access using the Okteto API
8ab77fb 
Signed-off-by: Pablo Chico de Guzman <pchico83@gmail.com>
@pchico83 pchico83 merged commit e3ba400 into master Apr 21, 2021
@pchico83 pchico83 deleted the pchico83/fix-e2e branch April 21, 2021 15:14
@Wignesh Wignesh mentioned this pull request Apr 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jLopezbarb jLopezbarb jLopezbarb approved these changes

@rberrelleza rberrelleza Awaiting requested review from rberrelleza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pchico83 @jLopezbarb