-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor for envs vars, labels and annotations #1444
Conversation
Signed-off-by: Javier López Barba <javier@okteto.com>
Signed-off-by: Javier López Barba <javier@okteto.com>
Signed-off-by: Javier López Barba <javier@okteto.com>
Signed-off-by: Javier López Barba <javier@okteto.com>
Codecov Report
@@ Coverage Diff @@
## master #1444 +/- ##
==========================================
+ Coverage 36.24% 36.51% +0.26%
==========================================
Files 79 79
Lines 7261 7276 +15
==========================================
+ Hits 2632 2657 +25
+ Misses 4301 4287 -14
- Partials 328 332 +4
Continue to review full report at Codecov.
|
pkg/model/dev.go
Outdated
@@ -127,7 +127,7 @@ type Dev struct { | |||
Image *BuildInfo `json:"image,omitempty" yaml:"image,omitempty"` | |||
Push *BuildInfo `json:"-" yaml:"push,omitempty"` | |||
ImagePullPolicy apiv1.PullPolicy `json:"imagePullPolicy,omitempty" yaml:"imagePullPolicy,omitempty"` | |||
Environment []EnvVar `json:"environment,omitempty" yaml:"environment,omitempty"` | |||
Environment Environments `json:"environment,omitempty" yaml:"environment,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Environment Environments `json:"environment,omitempty" yaml:"environment,omitempty"` | |
Environment Environment `json:"environment,omitempty" yaml:"environment,omitempty"` |
Signed-off-by: Javier López Barba <javier@okteto.com>
Fixes #1415
Proposed changes