Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use deploy key for the release #1445

Merged
merged 2 commits into from
Apr 23, 2021
Merged

use deploy key for the release #1445

merged 2 commits into from
Apr 23, 2021

Conversation

rberrelleza
Copy link
Member

it's better to use deploy keys than GitHub tokens

@derek
Copy link

derek bot commented Apr 23, 2021

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #1445 (dcb4e40) into master (b64902f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1445   +/-   ##
=======================================
  Coverage   36.24%   36.24%           
=======================================
  Files          79       79           
  Lines        7261     7261           
=======================================
  Hits         2632     2632           
  Misses       4301     4301           
  Partials      328      328           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b64902f...dcb4e40. Read the comment docs.

@rberrelleza rberrelleza merged commit 66ab7ad into master Apr 23, 2021
@rberrelleza rberrelleza deleted the rb/use-deploy-key branch April 23, 2021 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants