Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmarshal environment in stack #1478

Merged
merged 2 commits into from May 5, 2021

Conversation

jLopezbarb
Copy link
Contributor

Signed-off-by: Javier López Barba javier@okteto.com

Fixes #

Proposed changes

  • Use Environment unmarshalling in Okteto stack to have same functionality as in Okteto up

Signed-off-by: Javier López Barba <javier@okteto.com>
Signed-off-by: Javier López Barba <javier@okteto.com>
@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #1478 (4978bd3) into master (270d661) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1478      +/-   ##
==========================================
- Coverage   36.60%   36.59%   -0.02%     
==========================================
  Files          80       80              
  Lines        7614     7600      -14     
==========================================
- Hits         2787     2781       -6     
+ Misses       4471     4464       -7     
+ Partials      356      355       -1     
Impacted Files Coverage Δ
pkg/model/stack_serializer.go 47.22% <100.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 270d661...4978bd3. Read the comment docs.

@jLopezbarb jLopezbarb merged commit b7f34bd into master May 5, 2021
@jLopezbarb jLopezbarb deleted the jlopezbarb/use-envs-unmarshalling-for-stacks branch May 5, 2021 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants