Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip well known ports #1484

Merged
merged 3 commits into from May 7, 2021
Merged

Conversation

jLopezbarb
Copy link
Contributor

Signed-off-by: Javier López Barba javier@okteto.com

Fixes #1480

Proposed changes

  • Add debugger ports to be ignored when exposing the ports

Signed-off-by: Javier López Barba <javier@okteto.com>
@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #1484 (2177f65) into master (b9a8192) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1484   +/-   ##
=======================================
  Coverage   36.05%   36.06%           
=======================================
  Files          80       80           
  Lines        7821     7822    +1     
=======================================
+ Hits         2820     2821    +1     
  Misses       4644     4644           
  Partials      357      357           
Impacted Files Coverage Δ
pkg/model/stack_serializer.go 49.69% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9a8192...2177f65. Read the comment docs.

Signed-off-by: Javier López Barba <javier@okteto.com>
Signed-off-by: Javier López Barba <javier@okteto.com>
@pchico83 pchico83 merged commit f46cff1 into master May 7, 2021
@pchico83 pchico83 deleted the jlopezbarb/skip-well-known-debuggers branch May 7, 2021 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore host ports of well known remote debuggers
2 participants