Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exposed ports without making svc public #1497

Merged
merged 4 commits into from
May 10, 2021

Conversation

jLopezbarb
Copy link
Contributor

Signed-off-by: Javier López Barba javier@okteto.com

Fixes #

Proposed changes

  • Fixes add exposed ports to endpoints instead of making it public

Signed-off-by: Javier López Barba <javier@okteto.com>
@codecov
Copy link

codecov bot commented May 10, 2021

Codecov Report

Merging #1497 (2122868) into master (0edcbfb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1497   +/-   ##
=======================================
  Coverage   36.14%   36.15%           
=======================================
  Files          80       80           
  Lines        7891     7892    +1     
=======================================
+ Hits         2852     2853    +1     
  Misses       4684     4684           
  Partials      355      355           
Impacted Files Coverage Δ
pkg/model/stack_serializer.go 49.79% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0edcbfb...2122868. Read the comment docs.

Signed-off-by: Javier López Barba <javier@okteto.com>
Signed-off-by: Javier López Barba <javier@okteto.com>
Signed-off-by: Javier López Barba <javier@okteto.com>
@pchico83 pchico83 merged commit eb90a6c into master May 10, 2021
@pchico83 pchico83 deleted the jlopezbarb/fix-exposed-ports-without-making-public branch May 10, 2021 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants