Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for deprecated or windows fields #1532

Merged
merged 1 commit into from
May 17, 2021

Conversation

jLopezbarb
Copy link
Contributor

Signed-off-by: Javier López Barba javier@okteto.com

Fixes Adds support for windows scale field which is named cpu_count

Proposed changes

  • As windows users can not user scale, they may have cpu_count field instead, so this PR makes it possible to use it
  • Adds support for mem_limit, mem_reservation and cpus. Even that they are going to be deprecated, the composes that I found that manages memory and cpus still uses these fields

Signed-off-by: Javier López Barba <javier@okteto.com>
@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Merging #1532 (c10406f) into master (622e706) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1532      +/-   ##
==========================================
+ Coverage   35.96%   36.06%   +0.09%     
==========================================
  Files          88       88              
  Lines        8405     8405              
==========================================
+ Hits         3023     3031       +8     
+ Misses       5015     5011       -4     
+ Partials      367      363       -4     
Impacted Files Coverage Δ
pkg/model/stack_serializer.go 55.19% <100.00%> (+1.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 622e706...c10406f. Read the comment docs.

@jLopezbarb jLopezbarb merged commit c93f09e into master May 17, 2021
@jLopezbarb jLopezbarb deleted the jlopezbarb/add-deprecated-compose-fields branch May 17, 2021 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants