Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create volumes one by one and log it to the user #1533

Merged
merged 2 commits into from
May 17, 2021

Conversation

jLopezbarb
Copy link
Contributor

Signed-off-by: Javier López Barba javier@okteto.com

Fixes #1528

Proposed changes

  • Creates volumes one by one, after one is deployed it notificates the creation to the user

Signed-off-by: Javier López Barba <javier@okteto.com>
Signed-off-by: Javier López Barba <javier@okteto.com>
@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Merging #1533 (0bbcc73) into master (622e706) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1533   +/-   ##
=======================================
  Coverage   35.96%   35.97%           
=======================================
  Files          88       88           
  Lines        8405     8403    -2     
=======================================
  Hits         3023     3023           
+ Misses       5015     5013    -2     
  Partials      367      367           
Impacted Files Coverage Δ
pkg/cmd/stack/deploy.go 0.00% <0.00%> (ø)
pkg/cmd/stack/translate.go 69.86% <0.00%> (+1.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 622e706...0bbcc73. Read the comment docs.

Copy link
Contributor

@pchico83 pchico83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jLopezbarb can you also update the log.Success of endpoints from "Deployed endpoint..." to "Created endpoint..."'

@jLopezbarb jLopezbarb merged commit 14edbee into master May 17, 2021
@jLopezbarb jLopezbarb deleted the jlopezbarb/create-volumes-one-by-one branch May 17, 2021 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor "translatePersistentVolumeClaims" to list s.Volumes and create them one by one
2 participants