Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non named error #1536

Merged
merged 2 commits into from
May 17, 2021
Merged

Conversation

jLopezbarb
Copy link
Contributor

Signed-off-by: Javier López Barba javier@okteto.com

Fixes Fix a bug for non existing absolute paths results in named volume errors

Proposed changes

  • Creates a new function to check if a named volume is not declared on the top level struct

Signed-off-by: Javier López Barba <javier@okteto.com>
Signed-off-by: Javier López Barba <javier@okteto.com>
@codecov
Copy link

codecov bot commented May 16, 2021

Codecov Report

Merging #1536 (3bc32ef) into master (622e706) will increase coverage by 0.08%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1536      +/-   ##
==========================================
+ Coverage   35.96%   36.05%   +0.08%     
==========================================
  Files          88       88              
  Lines        8405     8413       +8     
==========================================
+ Hits         3023     3033      +10     
+ Misses       5015     5013       -2     
  Partials      367      367              
Impacted Files Coverage Δ
pkg/model/stack_serializer.go 54.73% <77.77%> (+1.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 622e706...3bc32ef. Read the comment docs.

@jLopezbarb jLopezbarb changed the title Creates services before deployments/stfs Fix non named error May 17, 2021
@jLopezbarb jLopezbarb merged commit 6cc0e9b into master May 17, 2021
@jLopezbarb jLopezbarb deleted the jlopezbarb/fix-non-named-volume-error branch May 17, 2021 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants