Fix forbidden error when updating volumes stack #1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Javier López Barba <javier@okteto.com>
pchico83
reviewed
May 17, 2021
pkg/cmd/stack/deploy.go
Outdated
| @@ -229,8 +229,11 @@ func deployVolume(ctx context.Context, volumeName string, s *model.Stack, c *kub | |||
| if old.Labels[okLabels.StackNameLabel] != s.Name { | |||
| return fmt.Errorf("name collision: the volume '%s' belongs to the stack '%s'", pvc.Name, old.Labels[okLabels.StackNameLabel]) | |||
| } | |||
| if err := volumes.Update(ctx, &pvc, c); err != nil { | |||
| return fmt.Errorf("error updating volume of service '%s': %s", pvc.Name, err.Error()) | |||
| if !volumes.IsEqual(&pvc, old) { | |||
There was a problem hiding this comment.
Can we do this in every case? if they are equal, it should do nothing.
Also, can you try that it is possible to change the volume size and the change takes effect in the volume?
Codecov Report
@@ Coverage Diff @@
## master #1538 +/- ##
==========================================
- Coverage 35.99% 35.97% -0.02%
==========================================
Files 88 88
Lines 8405 8414 +9
==========================================
+ Hits 3025 3027 +2
- Misses 5013 5019 +6
- Partials 367 368 +1
Continue to review full report at Codecov.
|
Signed-off-by: Javier López Barba <javier@okteto.com>
Signed-off-by: Javier López Barba <javier@okteto.com>
Signed-off-by: Javier López Barba <javier@okteto.com>
Signed-off-by: Javier López Barba <javier@okteto.com>
pchico83
reviewed
May 18, 2021
|
|
||
| old.Spec.Resources.Requests["storage"] = pvc.Spec.Resources.Requests["storage"] | ||
| for key, value := range pvc.Labels { | ||
| old.Labels[key] = value |
There was a problem hiding this comment.
should we remove the old labels?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Javier López Barba javier@okteto.com
Fixes: When there is a volume deployed and you want to update resources (Okteto stack deploy without running Okteto stack destroy), it gives you a forbidden error, because the volume name and storage class name are not set initially. These fields are given by Okteto cluster.
Proposed changes