Init okteto persistent volume from image content #1541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchico83
force-pushed
the
pchico83/init-from-image
branch
from
ceaf9a4
to
2c2deee
Compare
Codecov Report
@@ Coverage Diff @@
## master #1541 +/- ##
==========================================
+ Coverage 36.17% 36.31% +0.14%
==========================================
Files 88 88
Lines 8413 8390 -23
==========================================
+ Hits 3043 3047 +4
+ Misses 5007 4979 -28
- Partials 363 364 +1
Continue to review full report at Codecov.
|
rberrelleza
reviewed
May 17, 2021
pkg/k8s/deployments/translate.go
Outdated
| //OktetoInitFromImage name of the okteto init from image container | ||
| OktetoInitDataName = "okteto-init-data" | ||
| //OktetoInitVolumeName name of the okteto init container that initializes the persistent colume from image content | ||
| OktetoInitVolumeName = "okteto-init-volume" |
There was a problem hiding this comment.
if it's already a volume, do you think it might be redundant to call it -volume?
rberrelleza
approved these changes
May 17, 2021
Signed-off-by: Pablo Chico de Guzman <pchico83@gmail.com>
pchico83
force-pushed
the
pchico83/init-from-image
branch
from
2c2deee
to
488762d
Compare
jLopezbarb
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pablo Chico de Guzman pchico83@gmail.com
Initializing the volume from the image speeds up the first synchronization. It can also be used to reused the
node_modulesdependencies installed in the dev image