Initialize volumes from images #1546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Javier López Barba <javier@okteto.com>
jLopezbarb
commented
May 18, 2021
| Name: fmt.Sprintf("init-%s", svcName), | ||
| Image: "busybox", | ||
| Command: initContainerCommand, | ||
| VolumeMounts: initContainerVolumeMounts, |
There was a problem hiding this comment.
Should I propagate resources defined by the user for the main container?
Codecov Report
@@ Coverage Diff @@
## master #1546 +/- ##
==========================================
+ Coverage 36.29% 36.48% +0.18%
==========================================
Files 88 88
Lines 8403 8432 +29
==========================================
+ Hits 3050 3076 +26
- Misses 4986 4988 +2
- Partials 367 368 +1
Continue to review full report at Codecov.
|
pchico83
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Javier López Barba javier@okteto.com
Fixes #1540
Proposed changes