Inject only secrets without dots in key #1554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Javier López Barba <javier@okteto.com>
Codecov Report
@@ Coverage Diff @@
## master #1554 +/- ##
==========================================
- Coverage 36.27% 36.26% -0.02%
==========================================
Files 88 88
Lines 8407 8410 +3
==========================================
Hits 3050 3050
- Misses 4990 4993 +3
Partials 367 367
Continue to review full report at Codecov.
|
pchico83
reviewed
May 20, 2021
pkg/cmd/stack/translate.go
Outdated
| @@ -101,7 +101,9 @@ func translateServiceEnvFile(ctx context.Context, svc *model.Service, svcName, f | |||
| } | |||
|
|
|||
| for _, e := range envList { | |||
| secrets[e.Name] = e.Value | |||
| if !strings.Contains(e.Name, ".") { | |||
There was a problem hiding this comment.
Let's implement it in okteto.GetSecrets
Signed-off-by: Javier López Barba <javier@okteto.com>
pchico83
approved these changes
May 20, 2021
|
What is the use case that this is solving? And is it common for people to have a dot on their secrets? |
|
@rberrelleza "." secret in an internal okteto secret, like the github token. "." is not allowed for user defined secrets |
rberrelleza
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Javier López Barba javier@okteto.com
Fixes #
Proposed changes