Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a minimum of retries before timing out "okteto up" loops #1588

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

pchico83
Copy link
Contributor

@pchico83 pchico83 commented Jun 2, 2021

Signed-off-by: Pablo Chico de Guzman pchico83@gmail.com

When laptop is suspended in the middle of a loop, the reconnection logic is broken because we return a timeout error.

Adding a minimum number of retries solves the issue, although we will need a better mechanism to handle this scenario

@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #1588 (77724e2) into master (6babad6) will increase coverage by 0.01%.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1588      +/-   ##
==========================================
+ Coverage   36.98%   36.99%   +0.01%     
==========================================
  Files          90       90              
  Lines        8685     8690       +5     
==========================================
+ Hits         3212     3215       +3     
- Misses       5095     5097       +2     
  Partials      378      378              
Impacted Files Coverage Δ
cmd/up/activate.go 0.00% <0.00%> (ø)
pkg/k8s/deployments/crud.go 21.77% <0.00%> (ø)
pkg/k8s/pods/pod.go 15.55% <0.00%> (ø)
pkg/syncthing/syncthing.go 1.58% <0.00%> (ø)
pkg/ssh/manager.go 55.84% <75.00%> (+1.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6babad6...77724e2. Read the comment docs.

Signed-off-by: Pablo Chico de Guzman <pchico83@gmail.com>
@pchico83 pchico83 merged commit d354c3f into master Jun 2, 2021
@pchico83 pchico83 deleted the pchico83/retries branch June 2, 2021 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants