Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set update strategy to Recreate in dev mode #1589

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Conversation

pchico83
Copy link
Contributor

@pchico83 pchico83 commented Jun 2, 2021

Signed-off-by: Pablo Chico de Guzman pchico83@gmail.com

Using Recreate in dev mode deployments has several advantages:

  • It uses less resources because no additional pods are created during okteto up
  • It makes okteto up work better with multi-node clusters not managed by okteto, because the old edv pod and the new dev pod can go to different nodes, and the okteto volume will be reattached
  • It avoid syncthing issues when initializing the okteto volume from the content in the dev image, because no two pods can be running in parallel doing parallel write operations in the okteto volume

Signed-off-by: Pablo Chico de Guzman <pchico83@gmail.com>
@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #1589 (4fb0479) into master (6babad6) will increase coverage by 0.03%.
The diff coverage is 56.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1589      +/-   ##
==========================================
+ Coverage   36.98%   37.02%   +0.03%     
==========================================
  Files          90       90              
  Lines        8685     8700      +15     
==========================================
+ Hits         3212     3221       +9     
- Misses       5095     5100       +5     
- Partials      378      379       +1     
Impacted Files Coverage Δ
pkg/model/translation.go 0.00% <ø> (ø)
pkg/k8s/deployments/crud.go 23.10% <50.00%> (+1.33%) ⬆️
pkg/k8s/deployments/translate.go 85.79% <100.00%> (+0.07%) ⬆️
pkg/k8s/deployments/utils.go 87.87% <0.00%> (+3.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6babad6...4fb0479. Read the comment docs.

@pchico83 pchico83 merged commit 1a1341c into master Jun 2, 2021
@pchico83 pchico83 deleted the pchico83/recreate branch June 2, 2021 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants