Add stack endpoints

[jLopezbarb]

Signed-off-by: Javier López Barba javier@okteto.com

Proposed changes

• Adds a command to show the endpoints generated by a stack
• Show the endpoints at the end of okteto stack deploy --wait

[codecov]

Codecov Report

Merging #1866 (ccfb664) into master (ec977dd) will decrease coverage by 0.16%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1866      +/-   ##
==========================================
- Coverage   33.62%   33.46%   -0.17%     
==========================================
  Files         122      124       +2     
  Lines       13758    13825      +67     
==========================================
  Hits         4626     4626              
- Misses       8632     8699      +67     
  Partials      500      500              

Impacted Files	Coverage Δ
pkg/cmd/stack/endpoints.go	0.00% <0.00%> (ø)
pkg/okteto/stack.go	0.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec977dd...ccfb664. Read the comment docs.

[rberrelleza]

@jLopezbarb could you share a screenshot of how does it look like?

[jLopezbarb]

It seems weird to show that the endpoint has been deployed correctly.

[rlamana]

Why don't you show the endpoint after the successful message? And it could be an "info" line type.

[derek]

Thank you for your contribution. unfortunately, one or more of your commits are missing the required "Signed-off-by:" statement. Signing off is part of the Developer Certificate of Origin (DCO) which is used by this project.

Read the DCO and project contributing guide carefully, and amend your commits using the git CLI. Note that this does not require any cryptography, keys or special steps to be taken.

💡 Shall we fix this?

This will only take a few moments.

First, clone your fork and checkout this branch using the git CLI.

Next, set up your real name and email address:

git config --global user.name "Your Full Name"
git config --global user.email "you@domain.com"

Finally, run one of these commands to add the "Signed-off-by" line to your commits.

If you only have one commit so far then run: git commit --amend --signoff and then git push --force.
If you have multiple commits, watch this video.

Check that the message has been added properly by running "git log".

[jLopezbarb]

@rlamana

[rberrelleza]

@rlamana

I feel like that last part is too verbose. We show the stack name in both messages. Maybe the second one could just say "Endpoints available:"

[rlamana]

@jLopezbarb Agree with Ramiro. Update the screenshot when ready.

[jLopezbarb]

[rlamana]

@rberrelleza isn't it more correct to say "Available endpoints"?

[rberrelleza]

@rberrelleza isn't it more correct to say "Available endpoints"?

Not sure tbh. Maybe we should just use Endpoints:?

[jmacelroy]

@rberrelleza isn't it more correct to say "Available endpoints"?

Not sure tbh. Maybe we should just use Endpoints:?

They are both correct but I prefer Endpoints available: and think it's more common.

It's also listed on wikipedia as an example of postpositive adjective use :) It's one of those things I've never thought about but once I do I have no clue how English works, https://en.wikipedia.org/wiki/Postpositive_adjective, Certain adjectives are used fairly commonly in postpositive position. Present and past participles exhibit this behavior, as in all those entering should ..., one of the men executed was ..., but at will this can be considered to be a verbal rather than adjectival use (a kind of reduced relative clause). Similar behavior is displayed by many adjectives with the suffix -able or -ible (e.g. the best room available, the only decision possible, the worst choice imaginable, the persons liable).

[rlamana]

@jmacelroy English can be a bit of a nightmare when it comes to exceptions or special cases...

In that case, I like the Endpoints available: label.

[pchico83]

@jLopezbarb this is wrong. We could list the ingresses instead and get the URL from there. That wway endpoints are available in vanilla kubernetes clusters too