Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for namespace access #1946

Merged
merged 1 commit into from Nov 16, 2021
Merged

Conversation

jLopezbarb
Copy link
Contributor

@jLopezbarb jLopezbarb commented Nov 5, 2021

Signed-off-by: Javier López Barba javier@okteto.com

Proposed changes

  • Check if the user has access to the namespace ONLY when there is a command that saves context

Signed-off-by: Javier López Barba <javier@okteto.com>
@jLopezbarb jLopezbarb requested a review from a team November 5, 2021 10:59
@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #1946 (d8f5c8e) into master (155601a) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1946      +/-   ##
==========================================
- Coverage   33.58%   33.56%   -0.02%     
==========================================
  Files         122      122              
  Lines       13775    13782       +7     
==========================================
  Hits         4626     4626              
- Misses       8649     8656       +7     
  Partials      500      500              
Impacted Files Coverage Δ
cmd/context/create.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 155601a...d8f5c8e. Read the comment docs.

@pchico83 pchico83 merged commit 60ee441 into master Nov 16, 2021
@pchico83 pchico83 deleted the jlopezbarb/add-check-for-access branch November 16, 2021 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants