Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the OKTETO_URL configurable in integration tests #1947

Merged
merged 2 commits into from Nov 6, 2021

Conversation

pchico83
Copy link
Contributor

@pchico83 pchico83 commented Nov 5, 2021

Signed-off-by: Pablo Chico de Guzman pchico83@gmail.com

Proposed changes

This makes it possible to run Okteto CLI integration tests on different environments

@pchico83 pchico83 requested a review from a team November 5, 2021 13:29
@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #1947 (d3c438c) into master (8d66bf3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1947   +/-   ##
=======================================
  Coverage   33.42%   33.42%           
=======================================
  Files         122      122           
  Lines       13841    13841           
=======================================
  Hits         4626     4626           
  Misses       8715     8715           
  Partials      500      500           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d66bf3...d3c438c. Read the comment docs.

@jLopezbarb
Copy link
Contributor

I think this tests will fail when getting urls like in push action. https://github.com/okteto/okteto/blob/master/integration/push_test.go#L71

@pchico83
Copy link
Contributor Author

pchico83 commented Nov 5, 2021

I think this tests will fail when getting urls like in push action. https://github.com/okteto/okteto/blob/master/integration/push_test.go#L71

Good catch! I will update it

Signed-off-by: Pablo Chico de Guzman <pchico83@gmail.com>
Signed-off-by: Pablo Chico de Guzman <pchico83@gmail.com>
@pchico83 pchico83 merged commit b72a73e into master Nov 6, 2021
@pchico83 pchico83 deleted the pchico83/e2e-tests-url branch November 6, 2021 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants