Add make integration-actions command #1948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Javier López Barba <javier@okteto.com>
Codecov Report
@@ Coverage Diff @@
## master #1948 +/- ##
=======================================
Coverage 33.42% 33.42%
=======================================
Files 122 122
Lines 13841 13841
=======================================
Hits 4626 4626
Misses 8715 8715
Partials 500 500 Continue to review full report at Codecov.
|
pchico83
approved these changes
Nov 5, 2021
| @@ -40,7 +40,11 @@ test: | |||
|
|
|||
| .PHONY: integration | |||
| integration: | |||
| go test github.com/okteto/okteto/integration -tags=integration --count=1 -v -timeout 45m | |||
| go test github.com/okteto/okteto/integration -tags="common integration actions" --count=1 -v -timeout 45m | |||
There was a problem hiding this comment.
I think it should be fine with 15m timeout
pchico83
reviewed
Nov 5, 2021
| @@ -1,5 +1,5 @@ | |||
| //go:build integration | |||
| // +build integration | |||
| //go:build actions | |||
There was a problem hiding this comment.
could you add an envvar to skip the execution of the context action?
that why we can automate the execution of that tests only if the CLI version under test support the context command
Signed-off-by: Javier López Barba <javier@okteto.com>
Signed-off-by: Javier López Barba <javier@okteto.com>
pchico83
reviewed
Nov 5, 2021
integration/actions_test.go
Outdated
| @@ -205,6 +205,10 @@ func TestContextAction(t *testing.T) { | |||
| t.Skip("this test is not required for windows e2e tests") | |||
| return | |||
| } | |||
| if os.Getenv("OKTETO_SKIP_CTX_TEST") != "" { | |||
There was a problem hiding this comment.
Can we call it OKTETO_SKIP_CONTEXT_TEST to make it more verbouse?
Signed-off-by: Javier López Barba <javier@okteto.com>
Signed-off-by: Javier López Barba <javier@okteto.com>
Signed-off-by: Javier López Barba <javier@okteto.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Javier López Barba javier@okteto.com
Adds a make command to run only actions integration tests
Proposed changes