Adds support for private endpoint annotation #1953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Javier López Barba <javier@okteto.com>
pchico83
reviewed
Nov 8, 2021
| @@ -561,6 +561,9 @@ func translateService(svcName string, s *model.Stack) *apiv1.Service { | |||
| annotations := translateAnnotations(svc) | |||
| if s.Services[svcName].Public && annotations[model.OktetoAutoIngressAnnotation] == "" { | |||
There was a problem hiding this comment.
This should work even if s.Services[svcName].Public is false, no?
There was a problem hiding this comment.
We set it to true when there are exposed ports. This way we could support okteto-stack previous implementation
pchico83
approved these changes
Nov 8, 2021
Codecov Report
@@ Coverage Diff @@
## master #1953 +/- ##
=======================================
Coverage 33.42% 33.43%
=======================================
Files 122 122
Lines 13841 13843 +2
=======================================
+ Hits 4626 4628 +2
Misses 8715 8715
Partials 500 500
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Javier López Barba javier@okteto.com
Fixes #1895
Proposed changes
-Adds support for okteto dev private annotation