Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a HostKeyAlgorithms key to our SSH configuration #1960

Merged
merged 1 commit into from Nov 11, 2021

Conversation

rberrelleza
Copy link
Member

Fixes #1959

@rberrelleza rberrelleza requested a review from a team November 10, 2021 20:39
@derek
Copy link

derek bot commented Nov 10, 2021

Thank you for your contribution. unfortunately, one or more of your commits are missing the required "Signed-off-by:" statement. Signing off is part of the Developer Certificate of Origin (DCO) which is used by this project.

Read the DCO and project contributing guide carefully, and amend your commits using the git CLI. Note that this does not require any cryptography, keys or special steps to be taken.

💡 Shall we fix this?

This will only take a few moments.

First, clone your fork and checkout this branch using the git CLI.

Next, set up your real name and email address:

git config --global user.name "Your Full Name"
git config --global user.email "you@domain.com"

Finally, run one of these commands to add the "Signed-off-by" line to your commits.

If you only have one commit so far then run: git commit --amend --signoff and then git push --force.
If you have multiple commits, watch this video.

Check that the message has been added properly by running "git log".

@derek derek bot added the no-dco label Nov 10, 2021
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #1960 (d0b0e71) into master (e06fd24) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1960   +/-   ##
=======================================
  Coverage   33.30%   33.31%           
=======================================
  Files         125      125           
  Lines       13940    13941    +1     
=======================================
+ Hits         4643     4644    +1     
  Misses       8795     8795           
  Partials      502      502           
Impacted Files Coverage Δ
pkg/ssh/config.go 74.24% <ø> (ø)
pkg/ssh/ssh.go 77.50% <100.00%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e06fd24...d0b0e71. Read the comment docs.

@rberrelleza rberrelleza merged commit 7e0a3a4 into master Nov 11, 2021
@rberrelleza rberrelleza deleted the rb/add-hostKeyAlgorithms branch November 11, 2021 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't SSH into an okteto dev env with OpenSSH_8.8p1
3 participants