Add user id to context config #1962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Javier López Barba <javier@okteto.com>
pchico83
approved these changes
Nov 11, 2021
pchico83
reviewed
Nov 11, 2021
cmd/context/use.go
Outdated
| @@ -152,6 +152,14 @@ func getUserContext(ctx context.Context) (*okteto.UserContext, error) { | |||
| retries := 0 | |||
| for retries <= 3 { | |||
| userContext, err := client.GetUserContext(ctx) | |||
|
|
|||
| if okteto.Context().UserID == "" { | |||
There was a problem hiding this comment.
could we add a comment explaining why we need this code?
Codecov Report
@@ Coverage Diff @@
## master #1962 +/- ##
==========================================
- Coverage 33.31% 33.29% -0.02%
==========================================
Files 125 125
Lines 13941 13947 +6
==========================================
Hits 4644 4644
- Misses 8795 8801 +6
Partials 502 502
Continue to review full report at Codecov.
|
Signed-off-by: Javier López Barba <javier@okteto.com>
ifbyol
approved these changes
Nov 12, 2021
rberrelleza
reviewed
Nov 12, 2021
cmd/context/use.go
Outdated
|
|
||
| // If userID is not on context config file we add it and save it. | ||
| // this prevents from relogin to actual users | ||
| if okteto.Context().UserID == "" { |
There was a problem hiding this comment.
Should we only run this if it's an okteto context?
Signed-off-by: Javier López Barba <javier@okteto.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Javier López Barba javier@okteto.com
Proposed changes