Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jdm/stack healthcheck marshaling #1975

Merged
merged 2 commits into from Nov 16, 2021
Merged

Conversation

jmacelroy
Copy link
Contributor

Fixes #1974

I've attempted to swap out the regex and manual parsing of the curl healthchecks for stack manifests. This works on the existing test cases. I added another set of test cases that is closer to this logic and doesn't use the yaml parsing sections. If we like this I'm going to go back through and make sure I test all the known edge cases in both spots.

Jacob MacElroy added 2 commits November 15, 2021 20:50
There was at least one issue parsing for the url to transform the stack health check
to the data needed for a health check in kubernetes. The issue discovered was
an out of bounds on a slice issue when there was no path present.

This commit fixes #1974

Signed-off-by: Jacob MacElroy <jacob@okteto.com>
@jmacelroy jmacelroy requested a review from a team November 16, 2021 03:54
@derek derek bot added the no-dco label Nov 16, 2021
@derek
Copy link

derek bot commented Nov 16, 2021

Thank you for your contribution. unfortunately, one or more of your commits are missing the required "Signed-off-by:" statement. Signing off is part of the Developer Certificate of Origin (DCO) which is used by this project.

Read the DCO and project contributing guide carefully, and amend your commits using the git CLI. Note that this does not require any cryptography, keys or special steps to be taken.

💡 Shall we fix this?

This will only take a few moments.

First, clone your fork and checkout this branch using the git CLI.

Next, set up your real name and email address:

git config --global user.name "Your Full Name"
git config --global user.email "you@domain.com"

Finally, run one of these commands to add the "Signed-off-by" line to your commits.

If you only have one commit so far then run: git commit --amend --signoff and then git push --force.
If you have multiple commits, watch this video.

Check that the message has been added properly by running "git log".

@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #1975 (b531b69) into master (f5de696) will decrease coverage by 0.02%.
The diff coverage is 71.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1975      +/-   ##
==========================================
- Coverage   33.31%   33.28%   -0.03%     
==========================================
  Files         125      125              
  Lines       13935    13937       +2     
==========================================
- Hits         4642     4639       -3     
- Misses       8791     8794       +3     
- Partials      502      504       +2     
Impacted Files Coverage Δ
pkg/model/stack_serializer.go 65.03% <71.87%> (-0.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5de696...b531b69. Read the comment docs.

@pchico83 pchico83 merged commit fdf7764 into master Nov 16, 2021
@pchico83 pchico83 deleted the jdm/stack-healthcheck-marshaling branch November 16, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stack Trace Parsing Stack Healthcheck
3 participants