Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix master build #1977

Merged
merged 4 commits into from Nov 16, 2021
Merged

Fix master build #1977

merged 4 commits into from Nov 16, 2021

Conversation

jLopezbarb
Copy link
Contributor

Signed-off-by: Javier López Barba javier@okteto.com

Fixes master build

Proposed changes

  • Fixes master build
  • Adds new context test for checking if an user has access to namespace

Signed-off-by: Javier López Barba <javier@okteto.com>
@jLopezbarb jLopezbarb requested a review from a team November 16, 2021 10:26
Signed-off-by: Javier López Barba <javier@okteto.com>
Signed-off-by: Javier López Barba <javier@okteto.com>
Signed-off-by: Javier López Barba <javier@okteto.com>
@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #1977 (b88fb34) into master (66ab7ad) will decrease coverage by 2.38%.
The diff coverage is 12.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1977      +/-   ##
==========================================
- Coverage   36.24%   33.86%   -2.39%     
==========================================
  Files          79      125      +46     
  Lines        7261    13987    +6726     
==========================================
+ Hits         2632     4737    +2105     
- Misses       4301     8723    +4422     
- Partials      328      527     +199     
Impacted Files Coverage Δ
cmd/context/context.go 0.00% <0.00%> (ø)
cmd/context/list.go 0.00% <0.00%> (ø)
cmd/context/selector.go 0.00% <0.00%> (ø)
cmd/context/show.go 0.00% <0.00%> (ø)
cmd/context/use-namespace.go 0.00% <0.00%> (ø)
cmd/deploy/config.go 0.00% <0.00%> (ø)
cmd/deploy/proxy.go 0.00% <0.00%> (ø)
cmd/pipeline/deploy.go 0.00% <0.00%> (-16.95%) ⬇️
cmd/pipeline/destroy.go 0.00% <0.00%> (ø)
cmd/pipeline/pipeline.go 0.00% <0.00%> (ø)
... and 194 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e015a1a...b88fb34. Read the comment docs.

@jLopezbarb jLopezbarb merged commit 24f194e into master Nov 16, 2021
@jLopezbarb jLopezbarb deleted the jlopezbarb/fix-master-build branch November 16, 2021 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants