Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation message to okteto push command #2268

Merged
merged 2 commits into from
Mar 7, 2022

Conversation

jLopezbarb
Copy link
Contributor

Signed-off-by: Javier López Barba javier@okteto.com

Fixes #2165

Proposed changes

  • Add deprecation message if its not inside a okteto deploy (we would show the warning even when the user only has an okteto yaml)
  • Hide push from the list of available commands

Signed-off-by: Javier López Barba <javier@okteto.com>
@jLopezbarb jLopezbarb requested a review from a team February 17, 2022 11:53
@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2022

Codecov Report

Merging #2268 (8a45c0c) into master (ef58009) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2268   +/-   ##
=======================================
  Coverage   32.21%   32.21%           
=======================================
  Files         148      148           
  Lines       16950    16950           
=======================================
  Hits         5460     5460           
  Misses      10863    10863           
  Partials      627      627           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef58009...8a45c0c. Read the comment docs.

Short: "Build, push and redeploy source code to the target app",
Args: utils.MaximumNArgsAccepted(1, "https://okteto.com/docs/reference/cli/#push"),
Hidden: true,
Use: "push [svc]",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does okteto push without arguments still work if using an old manifest?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, It will get the old manifest and use that as the dev manifest

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2022

This pull request is stale because it has been open for 15 days with no activity. Comment on this pull request or it will be closed in 7 days

@github-actions github-actions bot added the stale label Mar 5, 2022
Signed-off-by: Javier López Barba <javier@okteto.com>
@github-actions github-actions bot removed the stale label Mar 7, 2022
@jLopezbarb jLopezbarb merged commit 79daee5 into master Mar 7, 2022
@jLopezbarb jLopezbarb deleted the jlopezbarb/deprecate-okteto-push branch March 7, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate okteto push
3 participants