-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix compose build integration #2305
Conversation
Signed-off-by: Javier López Barba <javier@okteto.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I run okteto build
and okteto deploy
on this repo:
https://github.com/pchico83/compose-getting-started
The image for vote
is registry.cloud.okteto.net/pchico83/compose-getting-started-vote:okteto-with-volume-mounts, but it should be the tag based on the sha256:56df26d0b78b786c248d633251ca
to make sure the containers are redeployed if the image has changed.
inferredManifest, err = inferredManifest.InferFromStack() | ||
if err != nil { | ||
return nil, err | ||
} | ||
//TODO: uncomment | ||
// inferredManifest.Deploy.Compose.Stack.Endpoints = devManifest.Deploy.Endpoints | ||
inferredManifest.Deploy.Compose.Stack.Endpoints = devManifest.Deploy.Endpoints |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am getting a segmentation fault error here when running okteto build
in this repo:
https://github.com/pchico83/compose-getting-started
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't repro it, are you using any flag on the build command?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, just okteto build
or okteto deploy
. Let me try again
Signed-off-by: Javier López Barba <javier@okteto.com>
Signed-off-by: Javier López Barba <javier@okteto.com>
Signed-off-by: Javier López Barba <javier@okteto.com>
Signed-off-by: Javier López Barba <javier@okteto.com>
Signed-off-by: Javier López Barba javier@okteto.com
Fixes: It was rebuilding the image on the deploy if there was a stack
Proposed changes