Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: up selector move correctly #2314

Merged
merged 1 commit into from
Mar 7, 2022
Merged

fix: up selector move correctly #2314

merged 1 commit into from
Mar 7, 2022

Conversation

jLopezbarb
Copy link
Contributor

Signed-off-by: Javier López Barba javier@okteto.com

Fixes #2291

Proposed changes

  • Order by length and alphabetically so the order keeps always the same
  • Fix move between options

@jLopezbarb
fix: up selector move correctly
865d5ad 
Signed-off-by: Javier López Barba <javier@okteto.com>
@jLopezbarb jLopezbarb requested a review from a team March 4, 2022 12:47
ifbyol
ifbyol approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@ifbyol ifbyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the branch with the repo I was having the error and It works perfectly!!

@jLopezbarb jLopezbarb merged commit ebe4162 into master Mar 7, 2022
@jLopezbarb jLopezbarb deleted the jlopezbarb/fix-up-selector branch March 7, 2022 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ifbyol ifbyol ifbyol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Development container selector is not working properly
2 participants
@jLopezbarb @ifbyol