Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show complete error trace on tty #2320

Merged
merged 2 commits into from
Mar 8, 2022

Conversation

jLopezbarb
Copy link
Contributor

Signed-off-by: Javier López Barba javier@okteto.com

Fixes #2288

Proposed changes

  • Write stdout in several lines
  • If a line contains colours, It will keep adding ... at the end, because we can not get which color is written and when writing new line the color becomes white

Screenshot

Captura de pantalla 2022-03-07 a las 13 05 40

Signed-off-by: Javier López Barba <javier@okteto.com>
Signed-off-by: Javier López Barba <javier@okteto.com>
@jLopezbarb jLopezbarb requested a review from a team March 7, 2022 12:31
@pchico83
Copy link
Contributor

pchico83 commented Mar 7, 2022

@jLopezbarb does this show the full output of the failed command? no matter how long is it?

@jLopezbarb
Copy link
Contributor Author

@jLopezbarb does this show the full output of the failed command? no matter how long is it?

This will show the full output while running the command and when failed it will show the same lines, it doesn't matter if it's 100 hundreds line long. There is some weird behaviour when the stdout lines have double whitespace but other than that I have not seen any other odd behaviour

@codecov-commenter
Copy link

Codecov Report

Merging #2320 (945651e) into master (ef58009) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2320   +/-   ##
=======================================
  Coverage   32.21%   32.21%           
=======================================
  Files         148      148           
  Lines       16950    16950           
=======================================
  Hits         5460     5460           
  Misses      10863    10863           
  Partials      627      627           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef58009...945651e. Read the comment docs.

@jLopezbarb jLopezbarb merged commit dedb1eb into master Mar 8, 2022
@jLopezbarb jLopezbarb deleted the jlopezbarb/show-complete-error-on-tty-deploy branch March 8, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

okteto up doesn't show complete error message when one of the deploy commands fails
3 participants