Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fallback buildv1 when no okteto file detected #2754

Merged

Conversation

AdrianPedriza
Copy link
Contributor

Signed-off-by: adripedriza adripedriza@gmail.com

Proposed changes

  • Create new error -> no content detected as okteto file
  • if we cannot detect any content from the build file then -> fallbackv1

Signed-off-by: adripedriza <adripedriza@gmail.com>
@AdrianPedriza AdrianPedriza requested a review from a team June 6, 2022 09:58
@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #2754 (7a7d597) into master (3043140) will increase coverage by 0.00%.
The diff coverage is 28.57%.

@@           Coverage Diff           @@
##           master    #2754   +/-   ##
=======================================
  Coverage   31.91%   31.91%           
=======================================
  Files         158      158           
  Lines       18574    18580    +6     
=======================================
+ Hits         5927     5929    +2     
- Misses      11947    11950    +3     
- Partials      700      701    +1     
Impacted Files Coverage Δ
pkg/model/manifest.go 14.80% <28.57%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3043140...7a7d597. Read the comment docs.

Signed-off-by: adripedriza <adripedriza@gmail.com>
@AdrianPedriza AdrianPedriza merged commit 670d6f7 into master Jun 6, 2022
@AdrianPedriza AdrianPedriza deleted the adrian/fix-fallback-buildv1-when-no-okteto-file_e2e branch June 6, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants