fix: compose flag on okteto up #2804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Javier López Barba <javier@okteto.com>
Codecov Report
@@ Coverage Diff @@
## master #2804 +/- ##
==========================================
+ Coverage 32.79% 32.83% +0.03%
==========================================
Files 158 158
Lines 18614 18626 +12
==========================================
+ Hits 6105 6115 +10
- Misses 11785 11786 +1
- Partials 724 725 +1
Continue to review full report at Codecov.
|
Signed-off-by: Javier López Barba <javier@okteto.com>
ifbyol
reviewed
Jun 15, 2022
Signed-off-by: Javier López Barba <javier@okteto.com>
Signed-off-by: Javier López Barba <javier@okteto.com>
| @@ -1019,6 +1020,21 @@ func (dev *Dev) ToTranslationRule(main *Dev, reset bool) *TranslationRule { | |||
|
|
|||
| return rule | |||
| } | |||
| func getSubPathFromLocalPath(localPath string) string { | |||
| wd, err := os.Getwd() | |||
There was a problem hiding this comment.
can we inject our dependencies for reading the file system? This will make unit testing much easier.
Optimally we would inject it at the top of our command, but for now to get this function's tests easier we can create the file reading dependencies in the caller
There was a problem hiding this comment.
That requires a whole refactor, which will be made in a future, so I think it will be better to work on it when we do the big refactor
ifbyol
approved these changes
Jun 15, 2022
jmacelroy
approved these changes
Jun 15, 2022
jLopezbarb
added a commit
that referenced
this pull request
Jun 16, 2022
* fix: compose flag on okteto up Signed-off-by: Javier López Barba <javier@okteto.com> * test: add test for non relative path Signed-off-by: Javier López Barba <javier@okteto.com> * refactor: encapsulate code into a function Signed-off-by: Javier López Barba <javier@okteto.com> * fix: unit tests Signed-off-by: Javier López Barba <javier@okteto.com>
jLopezbarb
added a commit
that referenced
this pull request
Jun 16, 2022
* fix: compose flag on okteto up Signed-off-by: Javier López Barba <javier@okteto.com> * test: add test for non relative path Signed-off-by: Javier López Barba <javier@okteto.com> * refactor: encapsulate code into a function Signed-off-by: Javier López Barba <javier@okteto.com> * fix: unit tests Signed-off-by: Javier López Barba <javier@okteto.com>
jLopezbarb
added a commit
that referenced
this pull request
Jun 16, 2022
* fix: compose flag on okteto up Signed-off-by: Javier López Barba <javier@okteto.com> * test: add test for non relative path Signed-off-by: Javier López Barba <javier@okteto.com> * refactor: encapsulate code into a function Signed-off-by: Javier López Barba <javier@okteto.com> * fix: unit tests Signed-off-by: Javier López Barba <javier@okteto.com>
jLopezbarb
added a commit
that referenced
this pull request
Jun 16, 2022
This reverts commit 8d63511.
jLopezbarb
added a commit
that referenced
this pull request
Jun 16, 2022
This reverts commit 8d63511.
jLopezbarb
added a commit
that referenced
this pull request
Jun 16, 2022
This reverts commit 8d63511. Signed-off-by: Javier López Barba <javier@okteto.com>
jLopezbarb
added a commit
that referenced
this pull request
Jun 16, 2022
jLopezbarb
added a commit
that referenced
this pull request
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Javier López Barba javier@okteto.com
Fixes #2789
Proposed changes