feat: ResourceEphemeralStorage #2902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for k8s resource type ephemeral-storage Signed-off-by: Dan Cohn <daniel.cohn@sabre.com>
Codecov Report
@@ Coverage Diff @@
## master #2902 +/- ##
==========================================
+ Coverage 33.02% 33.04% +0.01%
==========================================
Files 162 162
Lines 18811 18815 +4
==========================================
+ Hits 6213 6217 +4
Misses 11868 11868
Partials 730 730
Continue to review full report at Codecov.
|
|
Hi @dan-cohn-sabre, BTW really nice feature, thanks a lot for taking your time 😄 |
|
This pull request is stale because it has been open for 15 days with no activity. Comment on this pull request or it will be closed in 7 days |
Add tests for k8s resource type ephemeral-storage Signed-off-by: Dan Cohn <daniel.cohn@sabre.com>
jLopezbarb
approved these changes
Aug 3, 2022
|
@jLopezbarb could you take care of adding this information to the docs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for k8s resource type ephemeral-storage
Proposed changes
Add support for specifying "ephemeral-storage" requests and limits in the Okteto manifest. This is a very small improvement but can be critical in cases where namespace defaults are too restrictive.