-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix context checking when no manifest found #3008
fix context checking when no manifest found #3008
Conversation
Signed-off-by: adripedriza <adripedriza@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #3008 +/- ##
==========================================
+ Coverage 32.72% 32.73% +0.01%
==========================================
Files 188 188
Lines 19743 19748 +5
==========================================
+ Hits 6460 6465 +5
+ Misses 12519 12518 -1
- Partials 764 765 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Could we unify |
Agree with unifying both errors if they are used to represent the same. Also, careful with the error handling if we do the change |
Signed-off-by: adripedriza <adripedriza@gmail.com>
Signed-off-by: adripedriza <adripedriza@gmail.com>
Signed-off-by: adripedriza <adripedriza@gmail.com>
Signed-off-by: adripedriza <adripedriza@gmail.com>
Signed-off-by: adripedriza <adripedriza@gmail.com>
Can we run the E2E before merging it? |
Signed-off-by: adripedriza <adripedriza@gmail.com>
Signed-off-by: adripedriza <adripedriza@gmail.com>
i remember going thought this with #2969 can we check this case is covered with this change? |
Signed-off-by: adripedriza <adripedriza@gmail.com>
Signed-off-by: adripedriza <adripedriza@gmail.com>
Signed-off-by: adripedriza <adripedriza@gmail.com>
Signed-off-by: adripedriza <adripedriza@gmail.com>
Signed-off-by: adripedriza adripedriza@gmail.com
Fixes #2977
Proposed changes
discovery.ErrOktetoManifestNotFound
discovery.ErrOktetoManifestNotFound